Fix Vagrantfile for 2.0.3+ #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Vagrant 2.0.3 and up, the DEFAULT_SERVER_URL is frozen, so it cannot be changed. But earlier versions of Vagrant need this line to work. While we could mandate a minimum Vagrant version, this change would set the correct URL if it's wrong, and leave it alone if the Vagrant version is new enough not to need it. In hashicorp/vagrant#9442 this fix was posted by @reedy, credit where credit is due.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Vagrant 2.0.3 and up, the DEFAULT_SERVER_URL is frozen, so it cannot be changed. But earlier versions of Vagrant need this line to work. While we could mandate a minimum Vagrant version, this change would set the correct URL if it's wrong, and leave it alone if the Vagrant version is new enough not to need it.
Corrects this error:
In hashicorp/vagrant#9442 this fix was posted by @reedy, credit where credit is due.