Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bundler path option #55

Merged
merged 2 commits into from
Dec 7, 2013
Merged

Use bundler path option #55

merged 2 commits into from
Dec 7, 2013

Conversation

kenchan
Copy link
Contributor

@kenchan kenchan commented Dec 7, 2013

There was a problem occurs when you bundle update multiple projects (gems installing Git or Github repositories) simultaneously.

In summary, Bundler locked .git directory while upgrading a gem.(The root cause is a problem that occurs when the Bundler is parallel execution. 😢)

  • pros
    • independence
  • cons
    • speed
    • disk usage

how do you think?

@sanemat
Copy link
Owner

sanemat commented Dec 7, 2013

Independence is important!:muscle:

The issue:
When bundler updates gem(via git), at first checkout gem, then copy gem, so this checkout from multiple projects at the same time breaks bundle update.
see: https://github.com/bundler/bundler/blob/787cc7dad06b0b479019b4a6aad6669070c1fdc7/lib/bundler/source/git.rb#L138

https://twitter.com/kenchan/status/409162711398748160

sanemat added a commit that referenced this pull request Dec 7, 2013
@sanemat sanemat merged commit 1329d37 into sanemat:master Dec 7, 2013
@sanemat
Copy link
Owner

sanemat commented Dec 7, 2013

Build time:
1min30sec -> 7min (460%)
😰

@sanemat sanemat mentioned this pull request Dec 7, 2013
@kenchan kenchan deleted the use_bundler_path_option branch December 16, 2013 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants