Fix JSONResponse default content type (#2737)

sanic-org · Apr 10, 2023 · 6b9c1cc · 6b9c1cc
1 parent 4ad8168
commit 6b9c1cc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/sanic/response/types.py b/sanic/response/types.py
@@ -232,7 +232,7 @@ def __init__(
         body: Optional[Any] = None,
         status: int = 200,
         headers: Optional[Union[Header, Dict[str, str]]] = None,
-        content_type: Optional[str] = None,
+        content_type: str = "application/json",
         dumps: Optional[Callable[..., str]] = None,
         **kwargs: Any,
     ):

diff --git a/tests/test_response_json.py b/tests/test_response_json.py
@@ -213,3 +213,12 @@ def do_pop(request: Request, response: JSONResponse):
 
     _, resp = json_app.test_client.get("/json-pop")
     assert resp.body == json_dumps(["b"]).encode()
+
+
+def test_json_response_class_sets_proper_content_type(json_app: Sanic):
+    @json_app.get("/json-class")
+    async def handler(request: Request):
+        return JSONResponse(JSON_BODY)
+
+    _, resp = json_app.test_client.get("/json-class")
+    assert resp.headers["content-type"] == "application/json"