Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting broken in Travis builds #1514

Closed
sjsadowski opened this issue Mar 14, 2019 · 2 comments
Closed

linting broken in Travis builds #1514

sjsadowski opened this issue Mar 14, 2019 · 2 comments

Comments

@sjsadowski
Copy link
Contributor

Need to figure out what changed with linting - breaking for all builds now, seems like.
@sjsadowski sjsadowski changed the title linting broken in build linting broken in Travis builds Mar 14, 2019
@harshanarayana
Copy link
Contributor

harshanarayana commented Mar 14, 2019 •
edited
Loading

@sjsadowski Let me take a look

harshanarayana added a commit to harshanarayana/sanic that referenced this issue Mar 14, 2019
@harshanarayana
format: fix linter issue causing travis build failures (fix sanic-org…
0b62679 
…#1514)

Signed-off-by: Harsha Narayana <[email protected]>
@harshanarayana harshanarayana mentioned this issue Mar 14, 2019
Merged
@harshanarayana
Copy link
Contributor

@sjsadowski It was a minor import order issue related to webscoket package in testing utility. Opened a new PR to fix it.

sjsadowski pushed a commit that referenced this issue Mar 14, 2019
@harshanarayana @sjsadowski
format: fix linter issue causing travis build failures (fix #1514) (#…
269100e 
…1515)

Signed-off-by: Harsha Narayana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjsadowski @harshanarayana