Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeepAlive Timeout log level change to debug #1104

Merged

Conversation

arnulfojr
Copy link
Contributor

As discussed in this thread, I just made the logging change from INFO to DEBUG level when the Keep Alive Times out.

FYI @ashleysommer

@ashleysommer
Copy link
Member

LGTM 👍
But I would still like to see input from others about this too, some may argue that is should stay at INFO level.

@r0fls
Copy link
Contributor

r0fls commented Jan 31, 2018

I think DEBUG level makes sense, epsecially if it's confusing people.

@arnulfojr
Copy link
Contributor Author

arnulfojr commented Feb 1, 2018

For my point of view, it’s an INFO log level, but i saw that a lot of people are getting a bit confused so maybe is best if we set this as debug and we avoid getting issues that ask about that. Specially now that Asyncio is just taking off and a lot of people are getting on board and there’s going to be a lot of new devs using sanic.
In this sort of thinking, I give more weight on being clear+transparent to the community :)

@r0fls
Copy link
Contributor

r0fls commented Feb 1, 2018

Yep, 👍 I will merge this soon unless someone provides an argument against it.

@r0fls r0fls merged commit 3fe31ff into sanic-org:master Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants