-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eof method to close stream #2094
add eof method to close stream #2094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you add some tests that utilize the new style streaming response?
I would maybe look in tests/test_response.py
at one of the streaming_app
tests and use those as a starting point.
Codecov Report
@@ Coverage Diff @@
## main #2094 +/- ##
=============================================
- Coverage 92.146% 92.126% -0.020%
=============================================
Files 38 38
Lines 3476 3480 +4
Branches 575 575
=============================================
+ Hits 3203 3206 +3
- Misses 185 186 +1
Partials 88 88
Continue to review full report at Codecov.
|
@ajaygupta2790 Are you able to add tests for this? |
@sjsadowski @ahopkins No, I am not able to added cases yet. I am having difficulty understanding the existing ones and make changes |
No worries. I can do it 😎 Thanks for the PR. |
I was clearly using the wrong approach for this, will help in future PRs :) |
Resolves #2067