Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternatate classes on instantiation for Config and Sanic.ctx #2119

Merged
merged 8 commits into from
May 31, 2021

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Apr 17, 2021

Resolves #2115

@ahopkins ahopkins requested a review from a team as a code owner April 17, 2021 23:45
@ahopkins ahopkins marked this pull request as draft April 17, 2021 23:45
Copy link
Member

@Tronic Tronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

sanic/app.py Outdated Show resolved Hide resolved
@ahopkins ahopkins requested a review from Tronic May 20, 2021 05:58
@ahopkins ahopkins marked this pull request as ready for review May 20, 2021 05:58
@ahopkins ahopkins requested a review from a team May 20, 2021 05:58
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #2119 (21811f3) into main (1a352dd) will increase coverage by 0.123%.
The diff coverage is 87.770%.

❗ Current head 21811f3 differs from pull request most recent head 2497871. Consider uploading reports for the commit 2497871 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##              main     #2119       +/-   ##
=============================================
+ Coverage   92.133%   92.255%   +0.123%     
=============================================
  Files           38        38               
  Lines         3470      3525       +55     
  Branches       572       591       +19     
=============================================
+ Hits          3197      3252       +55     
  Misses         185       185               
  Partials        88        88               
Impacted Files Coverage Δ
sanic/server.py 88.175% <33.333%> (ø)
sanic/__main__.py 82.143% <68.750%> (+7.143%) ⬆️
sanic/asgi.py 93.396% <75.000%> (-0.835%) ⬇️
sanic/response.py 94.231% <75.000%> (-0.506%) ⬇️
sanic/http.py 77.574% <80.000%> (+0.083%) ⬆️
sanic/reloader_helpers.py 75.385% <80.000%> (-0.025%) ⬇️
sanic/blueprint_group.py 96.721% <84.615%> (-3.279%) ⬇️
sanic/app.py 92.683% <100.000%> (+0.060%) ⬆️
sanic/base.py 100.000% <100.000%> (ø)
sanic/blueprints.py 100.000% <100.000%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16b9e5...2497871. Read the comment docs.

Tronic
Tronic previously approved these changes May 20, 2021
@ahopkins ahopkins requested a review from a team as a code owner May 31, 2021 17:25
@ahopkins ahopkins merged commit b1f31f2 into main May 31, 2021
@ahopkins ahopkins deleted the alt-classes branch June 13, 2021 20:19
@ahopkins ahopkins mentioned this pull request Jun 21, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow an alternate configuration class or object to be passed to application objects
2 participants