Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update host test function names so they are not overwritten #2287

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

sjsadowski
Copy link
Contributor

When adding tests for #2284 test function names were accidentally reused. This PR fixes that.

@sjsadowski sjsadowski requested a review from Tronic October 24, 2021 16:34
@sjsadowski sjsadowski requested a review from a team as a code owner October 24, 2021 16:34
@codeclimate
Copy link

codeclimate bot commented Oct 24, 2021

Code Climate has analyzed commit d1319cf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (86% is the threshold).

This pull request will bring the total coverage in the repository to 86.5% (0.0% change).

View more on Code Climate.

@sjsadowski sjsadowski merged commit 2f30b57 into main Oct 24, 2021
@sjsadowski sjsadowski deleted the fix_host_tests branch October 24, 2021 17:29
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants