-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a docstring to Request.respond()
#2409
Conversation
Without a docstring this method will not show up in the Sphinx documentation.
Codecov Report
@@ Coverage Diff @@
## main #2409 +/- ##
=============================================
+ Coverage 87.110% 87.170% +0.059%
=============================================
Files 60 60
Lines 5004 5004
Branches 905 905
=============================================
+ Hits 4359 4362 +3
+ Misses 472 470 -2
+ Partials 173 172 -1
Continue to review full report at Codecov.
|
Co-authored-by: Ryu juheon <[email protected]>
I originally did so, I could not figure out how or why it failed so I reverted that change. It did not fix the seemingly unrelated test failure though. |
I made a couple of changes. We can worry about the type annotation issue another time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change. I'll deal with the flaky tests 🤬
Co-authored-by: Ryu juheon <[email protected]> Co-authored-by: Adam Hopkins <[email protected]>
Without a docstring this method will not show up in the Sphinx documentation.
See this relevant Discord conversation for information on how it was discovered.