Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing spaces in CLI error message #2485

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Add missing spaces in CLI error message #2485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sanic/cli/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ def _get_app(self):
if callable(app):
solution = f"sanic {self.args.module} --factory"
raise ValueError(
"Module is not a Sanic app, it is a"
"Module is not a Sanic app, it is a "
f"{app_type_name}\n"
" If this callable returns a"
" If this callable returns a "
f"Sanic instance try: \n{solution}"
Comment on lines -149 to 152
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ought to be using a single f string literal specifically to avoid this type of problem. And the line length limitation should be long enough to fit that on a single line (or allow breaking the rule for a literal).

These are just my notes for improving code quality in general (and for reconsideration of black settings), not asking for any immediate changes.

)

Expand Down