Fix Test Cases: test_http for Py3.9+, test_json_response_json for ujson 5.4.0+, and test_zero_downtime; Test Case Type Annotations
#2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2504 +/- ##
=========================================
Coverage 87.342% 87.342%
=========================================
Files 69 69
Lines 5554 5554
Branches 966 966
=========================================
Hits 4851 4851
Misses 510 510
Partials 193 193 Continue to review full report at Codecov.
|
ChihweiLHBird
changed the title
test_http for Py3.9+test_http for Py3.9+ and test_json_response_json for ujson > 5.4.0
ChihweiLHBird
changed the title
test_http for Py3.9+ and test_json_response_json for ujson > 5.4.0test_http for Py3.9+ and test_json_response_json for ujson 5.4.0+
ahopkins
requested changes
Jul 21, 2022
ChihweiLHBird
changed the title
test_http for Py3.9+ and test_json_response_json for ujson 5.4.0+test_http for Py3.9+, test_json_response_json for ujson 5.4.0+, and test_zero_downtime
ChihweiLHBird
changed the title
test_http for Py3.9+, test_json_response_json for ujson 5.4.0+, and test_zero_downtimetest_http for Py3.9+, test_json_response_json for ujson 5.4.0+, and test_zero_downtime; Test Case Type Annotations
ahopkins
reviewed
Jul 24, 2022
| @@ -75,7 +84,13 @@ def test_json_response_ujson(payload): | |||
| json(payload) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(NO_UJSON is True, reason="ujson not installed") | |||
| @pytest.mark.skipif( | |||
There was a problem hiding this comment.
We are going need to rethink this test. But will merge it for now.
ahopkins
reviewed
Jul 24, 2022
| return text(f"{request.conn_info.server}") | ||
|
|
||
|
|
||
| async def client(app, loop): | ||
| async def client(app: Sanic, loop: AbstractEventLoop): |
There was a problem hiding this comment.
There really is no reason to start annotating all of these. Especially those embedded handlers.
ahopkins
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case was fixed.