Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Request properties for HTTP method info #2516

Merged
merged 4 commits into from
Aug 10, 2022
Merged

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Aug 1, 2022

Adds three properties to Request object:

  • is_safe
  • is_idempotent
  • is_cacheable

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #2516 (e36a51e) into main (8e9342e) will increase coverage by 0.027%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##              main     #2516       +/-   ##
=============================================
+ Coverage   87.403%   87.430%   +0.027%     
=============================================
  Files           69        69               
  Lines         5565      5577       +12     
  Branches       969       969               
=============================================
+ Hits          4864      4876       +12     
  Misses         509       509               
  Partials       192       192               
Impacted Files Coverage Δ
sanic/constants.py 100.000% <100.000%> (ø)
sanic/request.py 95.396% <100.000%> (+0.108%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahopkins ahopkins marked this pull request as ready for review August 10, 2022 17:51
@ahopkins ahopkins requested a review from a team as a code owner August 10, 2022 17:51
@ahopkins ahopkins merged commit 7827b1b into main Aug 10, 2022
@ahopkins ahopkins deleted the request-method-properties branch August 10, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant