Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add some type hints #2517

Merged
merged 2 commits into from
Aug 2, 2022
Merged

style: add some type hints #2517

merged 2 commits into from
Aug 2, 2022

Conversation

SaidBySolo
Copy link
Member

For the typing of static, refer to the typing of FutureStatic class.

@SaidBySolo SaidBySolo requested a review from a team as a code owner August 2, 2022 04:17
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #2517 (8276c0e) into main (9cf38a0) will increase coverage by 0.053%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##              main     #2517       +/-   ##
=============================================
+ Coverage   87.392%   87.446%   +0.053%     
=============================================
  Files           69        69               
  Lines         5560      5560               
  Branches       966       966               
=============================================
+ Hits          4859      4862        +3     
+ Misses         509       507        -2     
+ Partials       192       191        -1     
Impacted Files Coverage Δ
sanic/app.py 88.718% <ø> (ø)
sanic/mixins/routes.py 93.700% <ø> (ø)
sanic/response.py 89.119% <ø> (ø)
sanic/config.py 98.591% <100.000%> (ø)
sanic/server/protocols/http_protocol.py 83.823% <0.000%> (+2.205%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf38a0...8276c0e. Read the comment docs.

@ahopkins ahopkins merged commit dee09d7 into sanic-org:main Aug 2, 2022
@SaidBySolo SaidBySolo deleted the style/add-type-hints branch August 2, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants