Always show server location in ASGI #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adam Hopkins <[email protected]> Co-authored-by: Zhiwei Liang <[email protected]>
ahopkins
changed the title
|
Our CI is broken? |
|
Or our testing on this is not sufficient. But I thought we had ASGI lifespan triggers tested. |
Can you also try to close and reopen this PR to see if we can trigger the CI? |
|
Will when I push some tests. It just didn't because it was originally changing targets. That doesn't trigger. |
|
Is there any solution for this in the meantime? Or just stay with 22.3 version? |
|
Will be releasing this probably tomorrow if that helps. |
Codecov Report
@@ Coverage Diff @@
## main #2522 +/- ##
=============================================
+ Coverage 87.430% 87.457% +0.026%
=============================================
Files 69 69
Lines 5577 5581 +4
Branches 969 969
=============================================
+ Hits 4876 4881 +5
+ Misses 509 508 -1
Partials 192 192
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahopkins
added a commit
that referenced
this pull request
Aug 11, 2022
Co-authored-by: Adam Hopkins <[email protected]> Co-authored-by: Zhiwei Liang <[email protected]> Co-authored-by: Néstor Pérez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2520
Co-authored-by: Adam Hopkins [email protected]
Co-authored-by: Zhiwei Liang [email protected]