-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor _static_request_handler
#2533
Conversation
Codecov ReportBase: 88.425% // Head: 88.430% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2533 +/- ##
=============================================
+ Coverage 88.425% 88.430% +0.005%
=============================================
Files 78 78
Lines 6471 6474 +3
Branches 1247 1246 -1
=============================================
+ Hits 5722 5725 +3
Misses 517 517
Partials 232 232
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Not sure that this adds much. |
Just added some, lol |
Seems useful to me and it doesn't add much code, so that is also good. Header dict |
Thanks for the feedback. I never heard about a such tool. Let me do a search for it. |
update
method to merge two dictionaries.if-modified-since
in request header is larger than the file modified time, 200 is still responded. 304 might be more appropriate.