Improve and fix some type annotations #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 87.504% // Head: 87.450% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2536 +/- ##
=============================================
- Coverage 87.504% 87.450% -0.054%
=============================================
Files 69 69
Lines 5602 5602
Branches 974 974
=============================================
- Hits 4902 4899 -3
- Misses 507 509 +2
- Partials 193 194 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ahopkins
reviewed
Aug 26, 2022
monosans
changed the title
seemethere
approved these changes
Sep 12, 2022
ahopkins
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to typing.Tuple docs:
To specify a variable-length tuple of homogeneous type, use literal ellipsis, e.g. Tuple[int, ...].All of the cases I fixed involve the use of variable-length tuples.