Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning and deprecation notice on violations #2537

Merged
merged 7 commits into from
Sep 15, 2022

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Aug 28, 2022

Closes #2166

Needs:

  • Tests

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Base: 87.528% // Head: 87.475% // Decreases project coverage by -0.053% ⚠️

Coverage data is based on head (172a6b4) compared to base (358498d).
Patch coverage: 90.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2537       +/-   ##
=============================================
- Coverage   87.528%   87.475%   -0.054%     
=============================================
  Files           69        69               
  Lines         5613      5621        +8     
  Branches       976       978        +2     
=============================================
+ Hits          4913      4917        +4     
- Misses         507       509        +2     
- Partials       193       195        +2     
Impacted Files Coverage Δ
sanic/handlers.py 97.321% <90.000%> (-0.756%) ⬇️
sanic/server/protocols/http_protocol.py 81.617% <0.000%> (-2.206%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins self-assigned this Aug 29, 2022
@ahopkins ahopkins marked this pull request as ready for review September 15, 2022 07:43
@ahopkins ahopkins requested a review from a team as a code owner September 15, 2022 07:43
@ahopkins ahopkins merged commit e501028 into main Sep 15, 2022
@ahopkins ahopkins deleted the exception-handler-uniqueness branch September 15, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

Enforce exception handler uniquness
2 participants