Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenericCreator for loading SSL certs in processes #2578

Merged
merged 10 commits into from
Oct 31, 2022
Merged

Conversation

ahopkins
Copy link
Member

Resolves #2577

@ahopkins ahopkins requested a review from a team as a code owner October 19, 2022 17:21
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 88.041% // Head: 88.047% // Increases project coverage by +0.006% 🎉

Coverage data is based on head (e7b6561) compared to base (3f4663b).
Patch coverage: 54.545% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2578       +/-   ##
=============================================
+ Coverage   88.041%   88.047%   +0.006%     
=============================================
  Files           71        71               
  Lines         5335      5338        +3     
  Branches       893       893               
=============================================
+ Hits          4697      4700        +3     
  Misses         461       461               
  Partials       177       177               
Impacted Files Coverage Δ
sanic/worker/loader.py 91.549% <54.545%> (-4.039%) ⬇️
sanic/server/websockets/impl.py 38.061% <0.000%> (+0.709%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sanic/worker/loader.py Outdated Show resolved Hide resolved
sanic/worker/loader.py Outdated Show resolved Hide resolved
sanic/worker/loader.py Outdated Show resolved Hide resolved
Tronic
Tronic previously approved these changes Oct 20, 2022
@ahopkins
Copy link
Member Author

This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there:

https://community.sanicframework.org/t/unknown-certificate-creator-error/1090/2

@ahopkins ahopkins merged commit d70636b into main Oct 31, 2022
@ahopkins ahopkins deleted the issue2577 branch October 31, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificates not created with mkcert or trustme raise a RuntimeError
2 participants