Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message if no apps found in registry #2585

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

scardozos
Copy link
Contributor

Fixes #2579

@scardozos scardozos requested a review from a team as a code owner October 22, 2022 13:34
sanic/app.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 88.018% // Head: 88.093% // Increases project coverage by +0.075% 🎉

Coverage data is based on head (5044ea3) compared to base (97f33f4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2585       +/-   ##
=============================================
+ Coverage   88.018%   88.093%   +0.075%     
=============================================
  Files           71        71               
  Lines         5333      5333               
  Branches       893       893               
=============================================
+ Hits          4694      4698        +4     
+ Misses         461       459        -2     
+ Partials       178       176        -2     
Impacted Files Coverage Δ
sanic/server/websockets/impl.py 38.061% <0.000%> (+0.945%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 6b9edfd into sanic-org:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In multiworker mode better error message if no apps
2 participants