Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sideeffects created by changing fork to spawn #2591

Merged
merged 4 commits into from
Oct 27, 2022

Conversation

SaidBySolo
Copy link
Member

@SaidBySolo SaidBySolo commented Oct 27, 2022

We discussed it on Discord.

This PR solves the problem that unintended behavior occurs when using the is keyword as the multiprocess start method is changed from spawn to fork.

@SaidBySolo SaidBySolo requested a review from a team as a code owner October 27, 2022 14:31
@SaidBySolo SaidBySolo changed the title fix: sideeffects created by changing to spawn fix: sideeffects created by changing fork to spawn Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 88.018% // Head: 88.093% // Increases project coverage by +0.075% 🎉

Coverage data is based on head (f46d031) compared to base (6b9edfd).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2591       +/-   ##
=============================================
+ Coverage   88.018%   88.093%   +0.075%     
=============================================
  Files           71        71               
  Lines         5333      5333               
  Branches       893       893               
=============================================
+ Hits          4694      4698        +4     
+ Misses         461       459        -2     
+ Partials       178       176        -2     
Impacted Files Coverage Δ
sanic/config.py 97.350% <100.000%> (ø)
sanic/mixins/startup.py 91.898% <100.000%> (ø)
sanic/server/websockets/impl.py 38.061% <0.000%> (+0.945%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 1c4925e into sanic-org:main Oct 27, 2022
@SaidBySolo SaidBySolo deleted the fix/is-default branch October 27, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants