Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for 3.11 support #2612

Merged
merged 14 commits into from
Dec 17, 2022
Merged

Test for 3.11 support #2612

merged 14 commits into from
Dec 17, 2022

Conversation

ahopkins
Copy link
Member

No description provided.

@ahopkins ahopkins requested a review from a team as a code owner November 29, 2022 10:17
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 88.562% // Head: 88.622% // Increases project coverage by +0.059% 🎉

Coverage data is based on head (d41934d) compared to base (154863d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2612       +/-   ##
=============================================
+ Coverage   88.562%   88.622%   +0.059%     
=============================================
  Files           81        81               
  Lines         6706      6706               
  Branches      1143      1143               
=============================================
+ Hits          5939      5943        +4     
+ Misses         529       527        -2     
+ Partials       238       236        -2     
Impacted Files Coverage Δ
sanic/blueprints.py 91.176% <ø> (ø)
sanic/server/websockets/impl.py 38.479% <0.000%> (+0.921%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins
Copy link
Member Author

I think there are some tweaks we need to make to the GH files. I honestly want to do bare minimum so we can rip them out next year.

@ChihweiLHBird
Copy link
Member

I think there are some tweaks we need to make to the GH files. I honestly want to do bare minimum so we can rip them out next year.

Why we will be able to remove them next year? Is there any successor of them?

@ahopkins
Copy link
Member Author

Something much simpler like what sanic-ext uses. Plus I've been playing with getting rid of codecov and just using coverage.py and posting back the html.

@ahopkins ahopkins requested a review from a team as a code owner December 17, 2022 18:47
@ahopkins ahopkins merged commit bfb54b0 into main Dec 17, 2022
@ahopkins ahopkins deleted the py311 branch December 17, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants