-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fork in limited cases #2624
Conversation
This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there: |
Codecov ReportBase: 88.614% // Head: 88.512% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2624 +/- ##
=============================================
- Coverage 88.614% 88.512% -0.103%
=============================================
Files 81 81
Lines 6684 6694 +10
Branches 1142 1143 +1
=============================================
+ Hits 5923 5925 +2
- Misses 524 529 +5
- Partials 237 240 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Supporting both
fork
andspawn
is a PITA. For reasons that drove us towards the big change in v22.9,spawn
should always be the default. This PR will not drop back tofork
unless someone expressly chooses it. For more information on why, see: https://community.sanicframework.org/t/sanic-app-name-xxx-already-in-use-while-running-in-docker