Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FALLBACK_ERROR_FORMAT for handlers that return empty() #2659

Merged
merged 6 commits into from
Feb 5, 2023
Merged

Use FALLBACK_ERROR_FORMAT for handlers that return empty() #2659

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cad2b84
Remove mapping of empty() to HTML so that it falls back to configured…
Tronic Jan 19, 2023
97e802a
Remove type mappings of all response types that don't directly corres…
Tronic Jan 29, 2023
8be0a37
Add a comment.
Tronic Jan 29, 2023
3e6aa9d
Merge branch 'main' into empty-errorpage-fallback
Tronic Jan 31, 2023
0b3774e
Add JSONResponse mapping
Tronic Feb 1, 2023
89f2d47
Merge branch 'main' of github.com:sanic-org/sanic into empty-errorpag…
ahopkins Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions sanic/errorpages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,16 +406,13 @@ def escape(text):
v: k for k, v in RENDERERS_BY_CONTENT_TYPE.items()
}

# Handler source code is checked for which response types it returns with the
# route error_format="auto" (default) to determine which format to use.
RESPONSE_MAPPING = {
Tronic marked this conversation as resolved.
Show resolved Hide resolved
"empty": "html",
"json": "json",
"text": "text",
"raw": "text",
"html": "html",
"file": "html",
"file_stream": "text",
"stream": "text",
"redirect": "html",
"JSONResponse": "json",
"text/plain": "text",
"text/html": "html",
"application/json": "json",
Expand Down