Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the status of socket before shutting down #2680

Merged
merged 2 commits into from
Feb 14, 2023
Merged

check the status of socket before shutting down #2680

merged 2 commits into from
Feb 14, 2023

Conversation

deounix
Copy link
Contributor

@deounix deounix commented Feb 11, 2023

This error happen when I'm trying to shutdown the server from the command line with CTRL+C

Platform: Windows 11

OSError: [WinError 10057] A request to send or receive data was disallowed because the socket is not connected and (when sending on a datagram socket using a sendto call) no address was supplied

Closes #2684

@deounix deounix requested a review from a team as a code owner February 11, 2023 21:04
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 88.583% // Head: 88.661% // Increases project coverage by +0.077% 🎉

Coverage data is based on head (32d7090) compared to base (5e7f699).
Patch coverage: 50.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2680       +/-   ##
=============================================
+ Coverage   88.583%   88.661%   +0.077%     
=============================================
  Files           87        87               
  Lines         6850      6853        +3     
  Branches      1171      1171               
=============================================
+ Hits          6068      6076        +8     
+ Misses         539       537        -2     
+ Partials       243       240        -3     
Impacted Files Coverage Δ
sanic/mixins/startup.py 90.807% <50.000%> (-0.390%) ⬇️
sanic/server/websockets/impl.py 38.479% <0.000%> (+0.691%) ⬆️
sanic/app.py 90.053% <0.000%> (+0.710%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sanic/mixins/startup.py Outdated Show resolved Hide resolved
@deounix deounix closed this by deleting the head repository Feb 12, 2023
@deounix deounix reopened this Feb 12, 2023
@ahopkins ahopkins added this pull request to the merge queue Feb 12, 2023
@ahopkins
Copy link
Member

I'd like to 🎉

First PR added to the merge queue. Very happy to have this feature finally.
image

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 12, 2023
@ahopkins ahopkins added this pull request to the merge queue Feb 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 14, 2023
@ahopkins ahopkins merged commit 6f5303e into sanic-org:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanic doesn't shutdown cleanly on Mac
2 participants