Simplified parse_content_header escaping #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
=============================================
- Coverage 88.705% 88.658% -0.048%
=============================================
Files 87 87
Lines 6853 6851 -2
Branches 1177 1177
=============================================
- Hits 6079 6074 -5
- Misses 533 534 +1
- Partials 241 243 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ahopkins
approved these changes
Mar 6, 2023
Tronic
added a commit
that referenced
this pull request
Mar 6, 2023
* tracerite var colors * Simplified parse_content_header escaping (#2707) * Move comments, darken bg color, move debug links to contextmanager * Lineup H2s * Make pretty --------- Co-authored-by: L. Kärkkäinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox has changed its escaping to conform with Chrome and https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data since when this function was originally implemented, and now escapes quotes as %22.
This PR updates the function to be RFC-compliant, removing that Firefox hack.