Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip middleware on RequestCancelled #2720

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Skip middleware on RequestCancelled #2720

merged 2 commits into from
Mar 20, 2023

Conversation

ahopkins
Copy link
Member

Closes #2689

@ahopkins ahopkins requested a review from a team as a code owner March 20, 2023 08:38
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 100.000% and project coverage change: +0.058 🎉

Comparison is base (53820bc) 88.617% compared to head (46fde24) 88.676%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2720       +/-   ##
=============================================
+ Coverage   88.617%   88.676%   +0.058%     
=============================================
  Files           87        87               
  Lines         6844      6844               
  Branches      1178      1178               
=============================================
+ Hits          6065      6069        +4     
+ Misses         537       535        -2     
+ Partials       242       240        -2     
Impacted Files Coverage Δ
sanic/http/http1.py 84.246% <100.000%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit ac1f561 into main Mar 20, 2023
@ahopkins ahopkins deleted the issue2689 branch March 20, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malfunction of middleware when the request aborted.
2 participants