Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync state tolerance #2725

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Sync state tolerance #2725

merged 1 commit into from
Mar 26, 2023

Conversation

ahopkins
Copy link
Member

No description provided.

@ahopkins ahopkins requested a review from a team as a code owner March 23, 2023 13:47
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 40.000% and project coverage change: -0.094 ⚠️

Comparison is base (6e1c787) 88.813% compared to head (1caeab5) 88.719%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2725       +/-   ##
=============================================
- Coverage   88.813%   88.719%   -0.094%     
=============================================
  Files           92        92               
  Lines         7035      7039        +4     
  Branches      1198      1198               
=============================================
- Hits          6248      6245        -3     
- Misses         539       544        +5     
- Partials       248       250        +2     
Impacted Files Coverage Δ
sanic/worker/manager.py 92.441% <40.000%> (-1.606%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit a8c2d77 into main Mar 26, 2023
@ahopkins ahopkins deleted the sync-state branch March 26, 2023 05:40
@ahopkins
Copy link
Member Author

This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there:

https://community.sanicframework.org/t/random-exceptions-with-workermanager/1154/5

@ahopkins
Copy link
Member Author

This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there:

https://community.sanicframework.org/t/random-exceptions-with-workermanager/1154/12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants