Fix Inner bug: TypeError: __init__() got an unexpected keyword argument 'escape_forward_slashes' #2740 #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor.py:86 as this argument is specific to ujson and isn't supported by the python standard library json.dumps
…dumpsas opposed to adding it to the code in places where it's being called. This is because this argument is only needed by ujson and not by the python standard library implementation of json.dumps
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2772 +/- ##
=============================================
+ Coverage 88.887% 88.946% +0.059%
=============================================
Files 92 92
Lines 6956 6957 +1
Branches 1185 1185
=============================================
+ Hits 6183 6188 +5
+ Misses 529 527 -2
+ Partials 244 242 -2
☔ View full report in Codecov by Sentry. |
ahopkins
approved these changes
Jul 5, 2023
moshe742
pushed a commit
to moshe742/sanic
that referenced
this pull request
Jul 8, 2023
…nt 'escape_forward_slashes' sanic-org#2740 (sanic-org#2772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.