Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve headers on different renderers - Issue 2749 #2774

Merged
merged 3 commits into from
Jul 9, 2023

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jul 9, 2023

Resolves #2749

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 100.000% and project coverage change: +0.103 🎉

Comparison is base (c17230e) 88.877% compared to head (dc349bc) 88.981%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2774       +/-   ##
=============================================
+ Coverage   88.877%   88.981%   +0.103%     
=============================================
  Files           92        92               
  Lines         6977      6979        +2     
  Branches      1190      1190               
=============================================
+ Hits          6201      6210        +9     
+ Misses         531       527        -4     
+ Partials       245       242        -3     
Impacted Files Coverage Δ
sanic/errorpages.py 98.780% <100.000%> (+0.015%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit c21999a into main Jul 9, 2023
@ahopkins ahopkins deleted the headers-response-renderers branch July 9, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers from Exceptions
1 participant