-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom typing to config and ctx #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopkins
changed the title
Add Sanic app instance typing
Add custom typing to config and ctx
Jul 11, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2785 +/- ##
=============================================
- Coverage 88.887% 88.806% -0.081%
=============================================
Files 92 92
Lines 7001 7031 +30
Branches 1194 1195 +1
=============================================
+ Hits 6223 6244 +21
- Misses 531 538 +7
- Partials 247 249 +2
☔ View full report in Codecov by Sentry. |
prryplatypus
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I have always found slightly annoying is that the reliance upon
app.ctx
andapp.config
lead to only partially typed objects. This PR attempts to resolve that by adding some generics intosanic.Sanic
andsanic.Request
:This can also be achieved by implication just through instantiation:
The goal of this PR is a nicer dev experience to be able to fully type out the ctx and config objects.
Given a simple handler with no custom typing:
Or, a fully custom typed:
A side benefit is that
sanic.Request.ctx
is now a lazy object and will not be instantiated until used. This is accomplished by introducing a new staticmethod on theRequest
object. It can be used to instantiate a custom ctx object as shown in the above screenshot. This is the only functional change in this PR: movingself.ctx = SimpleNamespace()
into the lazymake_context
pattern.TODO:
Request.ctx
Request
so that it can pass the ref in a handler for example