Refactoring unit test cases #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
=========================================
Coverage 88.387% 88.387%
=========================================
Files 92 92
Lines 7156 7156
Branches 1228 1228
=========================================
Hits 6325 6325
Misses 575 575
Partials 256 256 ☔ View full report in Codecov by Sentry. |
ahopkins
approved these changes
Jul 24, 2023
prryplatypus
approved these changes
Jul 24, 2023
ChihweiLHBird
approved these changes
Aug 10, 2023
|
@freddiewanah Thanks for submitting this. Any time we get an opportunity to improve tests it is a huge win. I'd be super happy to have your help working more on tests or anywhere else that you would be interested in contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first-time submitting PR here.
This PR improves the readability of the assert statements in the unit tests. These changes improve code quality (avoid test smells) by:
Using isinstance() is the more Pythonic way to check types, as it supports polymorphism, and also consistent with other test files within the project.
Simplifying code management. For example, instead of simply saying "application/octet-stream", use the parameter name(DEFAULT_HTTP_CONTENT_TYPE) so that developers could only update the value in one place.
Happy to update more related issues in the test code if needed :)