Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MOTD for extra data #2803

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Fix MOTD for extra data #2803

merged 6 commits into from
Nov 28, 2023

Conversation

ahopkins
Copy link
Member

image

This one has bugged me for a while. In short, the problem was that the alignment of keys ignored the extras. Therefore you could end up with misalignment and weird spacing. Also, the values were not breaking properly.

@ahopkins ahopkins requested a review from a team as a code owner August 21, 2023 13:39
prryplatypus
prryplatypus previously approved these changes Aug 21, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d93c10) 88.348% compared to head (1628b54) 88.354%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2803       +/-   ##
=============================================
+ Coverage   88.348%   88.354%   +0.006%     
=============================================
  Files           92        92               
  Lines         7175      7179        +4     
  Branches      1232      1233        +1     
=============================================
+ Hits          6339      6343        +4     
  Misses         581       581               
  Partials       255       255               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins ahopkins merged commit a0adf36 into main Nov 28, 2023
26 checks passed
@ahopkins ahopkins deleted the motd-fixes branch November 28, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants