Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not strip entity-headers with HTTP status 304 or 412 #2824

Merged
merged 13 commits into from
Jan 9, 2024
Merged

Do not strip entity-headers with HTTP status 304 or 412 #2824

merged 13 commits into from
Jan 9, 2024

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented Sep 20, 2023

Fix #2823

@Tronic Tronic requested a review from a team as a code owner September 20, 2023 19:01
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57d44f2) 88.039% compared to head (0e062e0) 88.016%.

❗ Current head 0e062e0 differs from pull request most recent head 84987c4. Consider uploading reports for the commit 84987c4 to get more accurate results

Additional details and impacted files 
@@              Coverage Diff               @@
##           23.12LTS     #2824       +/-   ##
==============================================
- Coverage    88.039%   88.016%   -0.024%     
==============================================
  Files            94        94               
  Lines          7433      7427        -6     
  Branches       1283      1280        -3     
==============================================
- Hits           6544      6537        -7     
- Misses          622       623        +1     
  Partials        267       267

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjsadowski sjsadowski self-assigned this Nov 1, 2023
sjsadowski
sjsadowski previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@sjsadowski sjsadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This accurately removes the check for entity headers and adds a test to prevent reversion for HTTP response code 412.

@ahopkins ahopkins changed the base branch from main to 23.12LTS January 9, 2024 17:26
@ahopkins ahopkins requested a review from a team as a code owner January 9, 2024 17:26
@ahopkins ahopkins merged commit cf71fc7 into 23.12LTS Jan 9, 2024
25 checks passed
@ahopkins ahopkins deleted the response-entity branch January 9, 2024 17:46
ahopkins added a commit that referenced this pull request Jun 23, 2024
@ahopkins
Merge Entity Header #2824
7fa2587
@ahopkins ahopkins mentioned this pull request Jun 23, 2024
Merged
ahopkins added a commit that referenced this pull request Jun 23, 2024
@ahopkins
Merge Entity Header #2824 (#2962)
c5d753a
@ChihweiLHBird ChihweiLHBird mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahopkins ahopkins ahopkins approved these changes

@sjsadowski sjsadowski sjsadowski left review comments

Assignees

@sjsadowski sjsadowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Sanic built-in server blocks for exactly 90 seconds on status code 412
4 participants
@Tronic @ahopkins @sjsadowski @prryplatypus