Improve functionality and consistency of Sanic.event() #2827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
app.event()
now takes additional argumentscondition
andexclusive
which behave the same as the same arguments toapp.signal()
blueprint.event()
now takes additional argumentcondition
which behaves the same as the same arguments toblueprint.signal()
app.event()
andblueprint.event()
now accept an event in enum form as well as str form, consistent withapp.signal()
andblueprint.signal()
app.event()
andblueprint.event()
now return a copy of the context dict passed toapp.dispatch()
(Signal event to return context #2088)blueprint.event()
now raisesTimeoutError
on timeout to be consistent withapp.event()
(previously, it just silently returned on timeout)blueprint.event()
now cancels any unfinished wait tasks instead of leaving them waiting