Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Ruff linter/formatter #2843

Closed
wants to merge 7 commits into from
Closed

Adopt Ruff linter/formatter #2843

wants to merge 7 commits into from

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented Oct 24, 2023 •
edited
Loading

Gotta go fast, so trying the fastest Python formatter as well (replaces isort, black, flake8 and bandit).

@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5a9658) 88.387% compared to head (905b54f) 88.385%.

Additional details and impacted files 
@@              Coverage Diff              @@
##              main     #2843       +/-   ##
=============================================
- Coverage   88.387%   88.385%   -0.002%     
=============================================
  Files           92        92               
  Lines         7156      7155        -1     
  Branches      1228      1228               
=============================================
- Hits          6325      6324        -1     
  Misses         575       575               
  Partials       256       256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/blueprints.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/blueprints.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/blueprints.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/blueprints.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/blueprints.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/config.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/config.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/config.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/headers.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/http/tls/context.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/mixins/startup.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/mixins/startup.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/mixins/startup.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/mixins/startup.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/request/parameters.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/request/parameters.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/request/types.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/request/types.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/request/types.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/response/convenience.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/response/convenience.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/response/convenience.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/response/convenience.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/response/types.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/router.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/utils.py Outdated Show resolved Hide resolved
Tronic
Tronic commented Oct 25, 2023
View reviewed changes
sanic/handlers/error.py Outdated Show resolved Hide resolved
@Tronic Tronic mentioned this pull request Oct 25, 2023
Closed
@Tronic
Copy link
Member Author

Tronic commented Oct 25, 2023

I've reset this branch (ruff) to an earlier stage where only about 90 lines are modified. The other PR mentioned above contains a more ambitious effort of modernizing the whole Sanic codebase and consequently a very large diff.

@ahopkins ahopkins mentioned this pull request Dec 4, 2023
Merged
@Tronic Tronic closed this Dec 4, 2023
@ahopkins ahopkins deleted the ruff branch December 5, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tronic