Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile cleanup #2848

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Makefile cleanup #2848

merged 2 commits into from
Nov 28, 2023

Conversation

ChihweiLHBird
Copy link
Member

@ChihweiLHBird ChihweiLHBird commented Nov 6, 2023

  • .PHONY now covers all commands.
  • fix-import command in the help menu has been renamed to isort as it was renamed in the definition previously.
  • python setup.py xxxx commands has been deprecated, so I removed or updated them. Installation command changed to pip install ., and testing commands have been removed as they were replaced by tox.
  • make pretty command has been added to the help menu.

@ChihweiLHBird ChihweiLHBird requested a review from a team as a code owner November 6, 2023 05:35
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f07ab5) 88.418% compared to head (aa02e83) 88.306%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2848       +/-   ##
=============================================
- Coverage   88.418%   88.306%   -0.112%     
=============================================
  Files           92        92               
  Lines         7158      7158               
  Branches      1229      1229               
=============================================
- Hits          6329      6321        -8     
- Misses         575       582        +7     
- Partials       254       255        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChihweiLHBird ChihweiLHBird changed the title Makefile's content cleanup Makefile cleanup Nov 26, 2023
@ahopkins ahopkins merged commit 36099bf into main Nov 28, 2023
26 checks passed
@ahopkins ahopkins deleted the zhiwei/makefile-cleanup branch November 28, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants