Add a REPL to the CLI #2859
Merged
Add a REPL to the CLI #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Sanic Community Discussion. There might be relevant details there: https://community.sanicframework.org/t/sanic-implement-shell-like-flask-shell/1234/5 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
=============================================
- Coverage 88.240% 88.104% -0.137%
=============================================
Files 93 93
Lines 7305 7305
Branches 1254 1254
=============================================
- Hits 6446 6436 -10
- Misses 600 606 +6
- Partials 259 263 +4 ☔ View full report in Codecov by Sentry. |
prryplatypus
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from a request in the forums: https://community.sanicframework.org/t/sanic-implement-shell-like-flask-shell/1234
The actual implementation adds a
--replflag to the CLI. By default,--devwill also enable it.The way it works is by opening a Python REPL in the main process. It will also enable a client for easy access to calling the app. But, one thing that it might confuse people is that altering the
appinstance in the main will obviously not make it available in the HTTP client. So there probably needs to be some kind of warnings. Also there should be some safety re: TTY, etc.