Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue:2832 Adjust documentation for using state properties within http -> https redirects doc. #2864

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

iAndriy
Copy link
Contributor

@iAndriy iAndriy commented Dec 3, 2023

This comes from a request to adjust documentation related to the http -> httpx redirects.
Issue link: #2832

Please note that signalize and finalize usage hasn't been adjusted, since more details needed to confirm that errors come from the sanic library and not related to local user setup.

@iAndriy iAndriy requested a review from a team as a code owner December 3, 2023 15:39
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d0231c) 88.325% compared to head (d639dc1) 88.383%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2864       +/-   ##
=============================================
+ Coverage   88.325%   88.383%   +0.057%     
=============================================
  Files           92        92               
  Lines         7178      7188       +10     
  Branches      1233      1234        +1     
=============================================
+ Hits          6340      6353       +13     
+ Misses         582       580        -2     
+ Partials       256       255        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins
Copy link
Member

ahopkins commented Dec 5, 2023

Thanks for this. Just as an FYI thought, the actual current deployment is here: https://github.com/sanic-org/sanic-guide

Coming soon the code your change will be released and the site will run from that codebase though.

@ahopkins ahopkins merged commit 85c617f into sanic-org:main Dec 5, 2023
26 checks passed
@iAndriy
Copy link
Contributor Author

iAndriy commented Dec 5, 2023

Thanks for this. Just as an FYI thought, the actual current deployment is here: https://github.com/sanic-org/sanic-guide

Coming soon the code your change will be released and the site will run from that codebase though.

good to know, thanks for sharing @ahopkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants