Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dynamic port fixture for test_app and helper function for tests which require port within a loop. #2882

Merged
merged 3 commits into from
Dec 25, 2023

Conversation

iAndriy
Copy link
Contributor

@iAndriy iAndriy commented Dec 20, 2023

No description provided.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee8e0ed) 88.391% compared to head (7280497) 88.268%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2882       +/-   ##
=============================================
- Coverage   88.391%   88.268%   -0.124%     
=============================================
  Files           93        93               
  Lines         7305      7305               
  Branches      1254      1254               
=============================================
- Hits          6457      6448        -9     
- Misses         592       598        +6     
- Partials       256       259        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/conftest.py Dismissed Show dismissed Hide dismissed
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. TY

@ahopkins ahopkins merged commit d1b7891 into sanic-org:main Dec 25, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants