support view instance for blueprint add_route method #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toughrogrammer
commented
Feb 14, 2017
toughrogrammer
commented
- make blueprint add_route method support view instance
- update documentation that doesn't specify url_prefix parameter
- update documentation that doesn't specify url_prefix parameter
r0fls
reviewed
Feb 14, 2017
sanic/blueprints.py
Outdated
| self.routes.append(route) | ||
| # Handle HTTPMethodView differently | ||
| if hasattr(handler, 'view_class'): | ||
| methods = frozenset(HTTP_METHODS) |
There was a problem hiding this comment.
Should a view default to having all methods defined? Maybe this should just be frozenset({'GET'})?
r0fls
reviewed
Feb 14, 2017
sanic/blueprints.py
Outdated
| """ | ||
| Creates a blueprint route from a function. | ||
| :param handler: Function to handle uri request. | ||
| :param handler: Function or class instance to handle uri request. |
There was a problem hiding this comment.
Should this be more explicit? For example "Function for handling uri requests. Accepts function, or class instance with a view_class method."
added 2 commits
February 14, 2017 17:15
- modify comment by r0fls
|
Thanks to your review. They are updated. |
r0fls
approved these changes
Feb 14, 2017
seemethere
approved these changes
Feb 14, 2017
|
@seemethere When the release version？Our project use it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.