Patch default strict slashes #900
Conversation
merge upstream master branch
| @@ -111,7 +112,7 @@ def decorator(listener): | |||
|
|
|||
| # Decorator | |||
| def route(self, uri, methods=frozenset({'GET'}), host=None, | |||
| strict_slashes=False, stream=False, version=None): | |||
| strict_slashes=None, stream=False, version=None): | |||
There was a problem hiding this comment.
Instead of strict_slashes=None I think it's better to do strict_slashes=self.strict_slashes since it's more compact. What do you think?
There was a problem hiding this comment.
self is not available at that moment i think.
There was a problem hiding this comment.
I understand your doubt but it seemed to work here: #896. I did the same type of thing a couple days ago when I made that, so should work :)
There was a problem hiding this comment.
yeah, it works in your case, because that is inside def route(self, ...), self is available then.
def route(self, ...):
# blablabla
self.router.add(..., merge_routes=self.merge_routes)Correct me if i am looking at wrong place.
| @@ -111,7 +112,7 @@ def decorator(listener): | |||
|
|
|||
| # Decorator | |||
| def route(self, uri, methods=frozenset({'GET'}), host=None, | |||
| strict_slashes=False, stream=False, version=None): | |||
| strict_slashes=None, stream=False, version=None): | |||
|
Nice work, once again. Thanks for the help! |
|
@yunstanford final thing -- can you add this to the docs? Just a quick mention is all that's needed. |
Fix #897