Add documentation for new Timeout values, after #939 #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E_TIMEOUT config values. Fixed some inconsistent default values.
r0fls
reviewed
Oct 16, 2017
| @@ -76,7 +76,7 @@ class HttpProtocol(asyncio.Protocol): | |||
|
|
|||
| def __init__(self, *, loop, request_handler, error_handler, | |||
| signal=Signal(), connections=set(), request_timeout=60, | |||
| response_timeout=60, keep_alive_timeout=15, | |||
| response_timeout=60, keep_alive_timeout=5, | |||
There was a problem hiding this comment.
What's the motivation for changing this?
There was a problem hiding this comment.
That is to keep all of the keep_alive_timeout default values the same.
In #939 I had:
Config.KEEP_ALIVE_TIMEOUT=5 in config.py
keep_alive_timeout=60 in server.py serve()
keep_alive_timeout=15 in HttpProtocol.__init__()
By default the Config.KEEP_ALIVE_TIMEOUT value was used and passed through to the others, so the 60 and the 15 were never used.
I changed them to 5 to be consistent with the default config value, and the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for REQUEST_TIMEOUT, RESPONSE_TIMEOUT and KEEP_ALIVE_TIMEOUT config values.
Fixed some inconsistent default values.