Allow required flavor props to be zero-valued #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to seed a flavor with 0 disk size fails because the 0-value get's pruned from the flavor spec. According to https://pkg.go.dev/encoding/json#Marshal the "omitempty" option in the struct definition is to blame for this. Remove it for some fields that are required for a flavor: RAM, Disk & vCPUs. While it's hard to conceive of a useful flavor without either RAM or CPUs, it might be required for testing -- just like the testing flavor with no disk size that just failed.
|
Has to be fixed before KVM rollout since flavors in KVM shouldn't have root disks at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to seed a flavor with 0 disk size fails because the 0-value get's pruned from the flavor spec.
According to https://pkg.go.dev/encoding/json#Marshal the "omitempty" option in the struct definition is to blame for this. Remove it for some fields that are required for a flavor: RAM, Disk & vCPUs.
While it's hard to conceive of a useful flavor without either RAM or CPUs, it might be required for testing -- just like the testing flavor with no disk size that just failed.