Catch exceptions by reference

Fixes `-Wcatch-value` warnings reported by gcc 8.2.0
saper · Dec 17, 2018 · 4f9f662 · 4f9f662
1 parent 6cb1927
commit 4f9f662
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/fn_strings.cpp b/src/fn_strings.cpp
@@ -14,15 +14,15 @@ namespace Sass {
       try {
        throw;
       }
-      catch (utf8::invalid_code_point) {
+      catch (utf8::invalid_code_point&) {
         std::string msg("utf8::invalid_code_point");
         error(msg, pstate, traces);
       }
-      catch (utf8::not_enough_room) {
+      catch (utf8::not_enough_room&) {
         std::string msg("utf8::not_enough_room");
         error(msg, pstate, traces);
       }
-      catch (utf8::invalid_utf8) {
+      catch (utf8::invalid_utf8&) {
         std::string msg("utf8::invalid_utf8");
         error(msg, pstate, traces);
       }

diff --git a/src/json.cpp b/src/json.cpp
@@ -402,7 +402,7 @@ char *json_encode_string(const char *str)
   try {
     emit_string(&sb, str);
   }
-  catch (std::exception) {
+  catch (std::exception&) {
     sb_free(&sb);
     throw;
   }
@@ -421,7 +421,7 @@ char *json_stringify(const JsonNode *node, const char *space)
     else
       emit_value(&sb, node);
   }
-  catch (std::exception) {
+  catch (std::exception&) {
     sb_free(&sb);
     throw;
   }