feat(rule-finder): Report any deprecated rules in use #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is absolutely awesome! 👍 |
|
Ping? Is there anything else that needs to be done before merging/releasing this? Thanks! |
|
Sorry for the delay, I catched a flu and was next to useless for anything. |
|
No worries. Hope you're feeling better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
-d/--deprecatedoption that reports any deprecated rules being used in the current configuration.The new option respects the
--no-errorand--no-coreoptions.In order to make this work, I had to refactor everything a bit.
_getPluginRules()and_getCoreRules()now both return aMapof ruleName => ruleDefinition so that we can determine which rules are deprecated when we need.With that change, I was able to move the handling of the
includeDeprecatedflag intoRuleFinderrather than passing it off to the_get*Rulesfunctions.Fixes #188
h/t @casto101 and @cseidholz for pairing on this with me.