-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] migrate travis-ci to Github Actions #338
Conversation
Crap, unfortunately this won't run until some workflow is merged to master. See #339. |
5baa6a7
to
5f93918
Compare
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 9
Lines ? 181
Branches ? 0
==========================================
Hits ? 181
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
0be10eb
to
03343e4
Compare
I think these test failures are likely legitimate - altho they might be related to our use of proxyquire in tests. The only remaining test failures are "timeout" ones. They all seem to fail consistently (and I can reproduce locally) in node 10 or below. We can't (and shouldn't) drop support for that, but we might still choose to make those optional so this can get landed. Thoughts? @jfmengels @sarbbottam @ta2edchimp |
100% is no longer possible in one run, since we have branching based on eslint version
fd2a5c8
to
58c049b
Compare
654854c
to
fa8890d
Compare
travis seems dead.