Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] migrate travis-ci to Github Actions #338

Merged
merged 4 commits into from
Nov 1, 2021
Merged

Conversation

ljharb
Copy link
Collaborator

@ljharb ljharb commented Oct 10, 2021

travis seems dead.

@ljharb
Copy link
Collaborator Author

ljharb commented Oct 10, 2021

Crap, unfortunately this won't run until some workflow is merged to master. See #339.

@ljharb ljharb mentioned this pull request Oct 10, 2021
3 tasks
@ljharb ljharb force-pushed the travis branch 7 times, most recently from 5baa6a7 to 5f93918 Compare October 10, 2021 16:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@4b6e9df). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #338   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         9           
  Lines             ?       181           
  Branches          ?         0           
==========================================
  Hits              ?       181           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
src/bin/find.js 100.00% <100.00%> (ø)
src/lib/cli-util.js 100.00% <100.00%> (ø)
src/lib/rule-finder.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6e9df...bc91e07. Read the comment docs.

@MichaelDeBoey

This comment has been minimized.

@ljharb ljharb force-pushed the travis branch 4 times, most recently from 0be10eb to 03343e4 Compare October 10, 2021 20:43
@ljharb
Copy link
Collaborator Author

ljharb commented Oct 10, 2021

I think these test failures are likely legitimate - altho they might be related to our use of proxyquire in tests.

The only remaining test failures are "timeout" ones. They all seem to fail consistently (and I can reproduce locally) in node 10 or below.

We can't (and shouldn't) drop support for that, but we might still choose to make those optional so this can get landed. Thoughts? @jfmengels @sarbbottam @ta2edchimp

@ljharb ljharb marked this pull request as ready for review October 21, 2021 17:08
100% is no longer possible in one run, since we have branching based on eslint version
@ljharb ljharb force-pushed the travis branch 2 times, most recently from 654854c to fa8890d Compare October 31, 2021 21:20
@ljharb ljharb merged commit bc91e07 into sarbbottam:master Nov 1, 2021
@ljharb ljharb deleted the travis branch November 1, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants