feat(exit): non-zero exit code for getUnusedRules

[sarbbottam]

use -n|no-error to suppress
fixed #31

/ @ta2edchimp

[codecov-io]

Current coverage is 100.00%

Merging #34 into master will not affect coverage as of 2105a94

@@            master     #34   diff @@
======================================
  Files            3       3       
  Stmts           70      74     +4
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             70      74     +4
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 2105a94

Powered by Codecov. Updated on successful CI builds.

[ta2edchimp]

Shouldn't proxyquire take care of the cache?

From its docs:

// ensure we don't get any module from the cache, but to load it fresh every time 
var proxyquire = require('proxyquire').noPreserveCache();

[ta2edchimp]

Respectively, extend the stub with

  'yargs': {
    '@global': true
  }

?

At the end of the day, if it works (and it does), I'm fine with it. Just asked for clarification ...

[sarbbottam]

Are you suggesting something like below?

var assert = require('assert')
-var proxyquire = require('proxyquire')
+var proxyquire = require('proxyquire').noPreserveCache();
 var sinon = require('sinon')

 var consoleLog = console.log // eslint-disable-line no-console
@@ -19,6 +19,9 @@ var stub = {
       getUnusedRules: getUnusedRules,
     }
   },
+  'yargs': {
+    '@global': true
+  }
 }

 describe('bin', function() {
@@ -36,8 +39,6 @@ describe('bin', function() {
   afterEach(function() {
     console.log = consoleLog // eslint-disable-line no-console
     process.exit = processExit
-    // purge yargs cache
-    delete require.cache[require.resolve('yargs')]
   })

   it('option -c|--current', function() {

could not get it working, looks like yargs is cached after the first require. Let me know if I have mis interpreted.

[ta2edchimp]

Yep, that is exactly what I thought of. I just remembered, that I had an issue with the caching behavior in another case ... Let's forget this. The explicit deletion from require.cache seems to work, so let's not overcomplicate this.

(I have to dig into this deeper some time, there has to be a way to accomplish this with proxyquire's own means... if not, it has to be a bug.)

[sarbbottam]

Is it good to merge then?

[ta2edchimp]

LGTM! 👍