feat(bin): 0 exit code when no unused rules found #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinspecker
force-pushed
the
zero-when-no-unused-rules-found
branch
3 times, most recently
from
d5d7d94 to
18068a3
Compare
| @@ -20,19 +20,23 @@ var getRuleFinder = require('./rule-finder') | |||
| var specifiedFile = argv._[0] | |||
|
|
|||
| var ruleFinder = getRuleFinder(specifiedFile) | |||
| var noUnusedRulesFound = false | |||
There was a problem hiding this comment.
noUnusedRulesFound is not required, ...
👍 |
Before, no unused rules always returned a non-zero exit code even when no unused rules were found. Now, -u only returns a non-zero exit code when an unused rule is found. This makes eslint-find-rules an even better tool by being able to be ran on CI when ESLint updates for configs.
dustinspecker
force-pushed
the
zero-when-no-unused-rules-found
branch
from
18068a3 to
893c5c0
Compare
|
Good catch, that's way better! |
|
Thanks for the PR! |
|
@dustinspecker please add yourself to all-contributorsrc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, no unused rules always returned a non-zero exit code even when
no unused rules were found. Now, -u only returns a non-zero exit code
when an unused rule is found.
This makes eslint-find-rules an even better tool by being able to
be ran on CI when ESLint updates for configs.