external dependencies #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ading up files for parsing.
jbirddog
reviewed
Sep 7, 2022
| """Locate all calls to external BPMN and DMN files, and store their | ||
| ids in our list of dependencies""" | ||
| for call_activity in xpath('.//bpmn:callActivity'): | ||
| self.dependencies.append(call_activity.get('calledElement')) |
There was a problem hiding this comment.
Not sure if you can get into a situation where you have duplicate dependencies, like multiple callActivity nodes that have the same calledElement? If so, perhaps a set for the dependencies?
There was a problem hiding this comment.
excellent point, I'll assure it's a unique set.
Allow accessing process dependencies and dmn dependencies separately.
essweine
approved these changes
Sep 7, 2022
| Because DMN references vary between Camunda and Spiff, need to test that | ||
| both methods will work. | ||
| """ | ||
|
|
There was a problem hiding this comment.
For the record, I don't like camunda and spiff appearing here, though given the way our test suite is set up, there probably isn't a better way.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to check which dependencies exist after adding one or more files to the BPMN parser.