Feature/xml validation #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lid BPMN Diagrams.
Changes required:
Message Path
------------
In collaborations, the correlation property retrieval expression should be in a 'messagePath' tag, not a 'formalExpression'
(formalExpression was the TYPE that it should be, but the name must be messagePath.)
Invalid
```xml
<bpmn:correlationPropertyRetrievalExpression messageRef="love_letter">
<bpmn:formalExpression>lover_name</bpmn:formalExpression>
</bpmn:correlationPropertyRetrievalExpression>
```
valid:
```
<bpmn:correlationPropertyRetrievalExpression messageRef="love_letter">
<bpmn:messagePath>lover_name</bpmn:messagePath>
</bpmn:correlationPropertyRetrievalExpression>
```
IOSpecifications
------------------
* Empty IO Specifications are not permitted.
* IO Specifications must have an inputSet and outputSet tags. (which themselves can be empty)
valid:
```xml
<ioSpecification>
<dataInput id="in_1" name="input 1" />
<dataOutput id="out_1" name="output 1" />
<inputSet name="Inputs" id="INS_1">
<dataInputRefs>id_1</dataInputRefs>
</inputSet>
<outputSet name="Outputs" id="OUTS_1">
<dataOutputRefs>out_1</dataOutputRefs>
</outputSet>
</ioSpecification>
```
|
I don't have an issue with the changes you made, but I have a few more things that I need to add (mainly around validation for our extensions), so don't merge this yet. |
…t to pass consistently in CI.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.